Open
Conversation
wconstab
reviewed
Jan 29, 2026
| def forward(self, x): | ||
| x = self.linear1(x) | ||
| # Constrain intermediate result to be sharded | ||
| x = with_sharding_constraint(x, (Shard(0),), device_mesh_1d) |
Contributor
There was a problem hiding this comment.
one thought: it we used 'x.redistribute(Shard(0))` which is valid dtensor code as a way for autop to infer constraints, would that be a way to avoid having autop vs normal dtensor code diverge?
wconstab
reviewed
Jan 29, 2026
Contributor
wconstab
left a comment
There was a problem hiding this comment.
seems OK to me, but i do have a question about whether we'd want to introduce autop-specific code into the model code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_sharding_constraintoperator similar to JAX's API for constraining intermediate tensor shardingsImplementation Details
The
with_sharding_constraint(x, shardings, device_mesh=None)function:local_mapwith matchingin_placementsandout_placementsto enforce the constraintlocal_mapregion if device_mesh is not providedclone()inside the identity function to avoid input-to-output aliasing issues with dynamo's HOP tracingExample Usage
Test plan